Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for PHP 8.4 #198

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Add support for PHP 8.4 #198

merged 1 commit into from
Oct 14, 2024

Conversation

ADmad
Copy link
Contributor

@ADmad ADmad commented Oct 12, 2024

Q A
Documentation yes/no
Bugfix yes/no
BC Break yes/no
New Feature yes/no
RFC yes/no
QA yes/no

Description

@ADmad
Copy link
Contributor Author

ADmad commented Oct 12, 2024

The blocker for getting the testsuite passing is vimeo/psalm still not supporting PHP 8.4 vimeo/psalm#10928

@ADmad ADmad force-pushed the php-8.4-support branch 2 times, most recently from 2055644 to 38c2ef0 Compare October 12, 2024 05:46
@gsteel
Copy link
Member

gsteel commented Oct 14, 2024

Conflicting with older versions of amphp should get CI over the line here:
https://github.com/mezzio/mezzio-session-ext/pull/56/files

@ADmad
Copy link
Contributor Author

ADmad commented Oct 14, 2024

Conflicting with older versions of amphp should get CI over the line here

Thanks for the tip, done.

@gsteel gsteel added this to the 3.5.0 milestone Oct 14, 2024
@gsteel gsteel self-assigned this Oct 14, 2024
gsteel
gsteel approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ADmad :)

@gsteel gsteel merged commit 143a163 into laminas:3.5.x Oct 14, 2024
17 checks passed
@ADmad ADmad deleted the php-8.4-support branch October 14, 2024 12:08
koka500000
koka500000 reviewed Nov 24, 2024
View reviewed changes
Copy link

@koka500000 koka500000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koka500000 koka500000 koka500000 approved these changes

@gsteel gsteel gsteel approved these changes

@samsonasik samsonasik samsonasik approved these changes

Assignees

@gsteel gsteel

Labels
Enhancement
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ADmad @gsteel @samsonasik @koka500000