Remove PhpInputStream #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main reason this existed was because prior to PHP 5.6, `php://input` was read-once and non-seekable. As of 5.6, it's reusable AND seekable, which means there's no reason to keep the special implementation, particularly as it causes bugs (see laminas#150) This patch: - Removes the class - Updates the `ServerRequest` to, when a body of `php://input` is detected, create a read-only `Stream` instance with that value. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
weierophinney
force-pushed
the
fix/php-input-stream-get-contents
branch
from
34d919c
to
bfbeacd
Compare
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The main
PhpInputStreamexisted was because prior to PHP 5.6,php://inputwas read-once and non-seekable.As of 5.6, it's reusable AND seekable, which means there's no reason to keep the special implementation, particularly as it causes bugs (see #150)
This patch:
ServerRequestto, when a body ofphp://inputis detected, create a read-onlyStreaminstance with that value.Fixes #150