Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop legacy helper functions in Zend namespace #146

Merged
merged 3 commits into from
May 2, 2023

Conversation

Xerkus
Copy link
Member

@Xerkus Xerkus commented May 1, 2023

Q A
Documentation no
Bugfix no
BC Break yes
New Feature no
RFC no
QA no

Description

Legacy helper functions in Zend namespace were left in place to facilitate migration but no longer needed.

@Xerkus Xerkus added this to the 3.0.0 milestone May 1, 2023
@Xerkus
Copy link
Member Author

Xerkus commented May 1, 2023

Psalm issue: UndefinedAttributeClass can be suppressed with issue handler using targeted referencedClass.

When running on 8.2 psalm targets 8.0 and complains with

ERROR: InvalidAttribute - src/Uri.php:246:11 - The class SensitiveParameter doesn't have the Attribute attribute (see https://psalm.dev/242)
        #[SensitiveParameter]

This issue does not have referencedClass to make targeted issue handler and it can't be baselined either.

psalm.xml.dist Outdated Show resolved Hide resolved
@Xerkus Xerkus force-pushed the feature/drop-legacy-remnants branch from f0424fb to b8331a0 Compare May 2, 2023 09:19
psalm-baseline.xml Outdated Show resolved Hide resolved
Xerkus added 3 commits May 2, 2023 19:54
Signed-off-by: Aleksei Khudiakov <[email protected]>
Signed-off-by: Aleksei Khudiakov <[email protected]>
@Xerkus Xerkus force-pushed the feature/drop-legacy-remnants branch from b8331a0 to f88a19c Compare May 2, 2023 09:54
@Ocramius Ocramius self-assigned this May 2, 2023
@Ocramius Ocramius merged commit ec41bf7 into laminas:3.0.x May 2, 2023
@Ocramius
Copy link
Member

Ocramius commented May 2, 2023

Thanks @Xerkus!

@Xerkus Xerkus deleted the feature/drop-legacy-remnants branch May 2, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants