Apply PHP 8.0 Syntax and constructor promotion #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
samsonasik
commented
Dec 9, 2022
| */ | ||
| public function __construct($viewRenderer, Options $options) | ||
| public function __construct(protected $renderer, Options $options) |
There was a problem hiding this comment.
Yes, $renderer can be promoted property, since both property and parameter type are mixed (not typed)
and Options need to be kept as is as property not typed, and parameter typed.
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
|
All green 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Abdul Malik Ikhsan [email protected]
Description
Since composer.json require php 8.0, php 8.0 syntax can constuctor promotion can be applied.