-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop PHP 7.3 support, update laminas/laminas-coding-standard
and add vimeo/psalm
#52
Merged
internalsystemerror
merged 6 commits into
laminas:2.4.x
from
internalsystemerror:upgrade-dependencies
Sep 12, 2022
Merged
Drop PHP 7.3 support, update laminas/laminas-coding-standard
and add vimeo/psalm
#52
internalsystemerror
merged 6 commits into
laminas:2.4.x
from
internalsystemerror:upgrade-dependencies
Sep 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gary Lockett <[email protected]>
Signed-off-by: Gary Lockett <[email protected]>
Signed-off-by: Gary Lockett <[email protected]>
Signed-off-by: Gary Lockett <[email protected]>
Signed-off-by: Gary Lockett <[email protected]>
gsteel
reviewed
Sep 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than a few nitpicks!
internalsystemerror
force-pushed
the
upgrade-dependencies
branch
from
September 12, 2022 17:29
5b0e711
to
eb7c510
Compare
gsteel
reviewed
Sep 12, 2022
Signed-off-by: Gary Lockett <[email protected]>
internalsystemerror
force-pushed
the
upgrade-dependencies
branch
from
September 12, 2022 17:34
eb7c510
to
33080b2
Compare
Ready for re-review now |
gsteel
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
laminas/laminas-coding-standard
to~2.4.0
(closes Update dependency laminas/laminas-coding-standard to v2 #48)vimeo/psalm
with a generated baseline