Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop PHP 7.3 support, update laminas/laminas-coding-standard and add vimeo/psalm #52

Merged

Conversation

internalsystemerror
Copy link
Member

@internalsystemerror internalsystemerror commented Sep 11, 2022

Q A
Documentation no
Bugfix no
BC Break no
New Feature yes
RFC no
QA yes

Description

This PR:

Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than a few nitpicks!

src/Exception/ExceptionInterface.php Outdated Show resolved Hide resolved
src/Exception/SerializableException.php Outdated Show resolved Hide resolved
src/Module.php Show resolved Hide resolved
src/Module.php Show resolved Hide resolved
Signed-off-by: Gary Lockett <[email protected]>
@internalsystemerror
Copy link
Member Author

Ready for re-review now

@internalsystemerror internalsystemerror merged commit 975e4b3 into laminas:2.4.x Sep 12, 2022
@internalsystemerror internalsystemerror added this to the 2.4.0 milestone Sep 12, 2022
@internalsystemerror internalsystemerror deleted the upgrade-dependencies branch September 12, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants