This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
Switch from container-interop/container-interop to psr/container in a backward compatible manner
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch switches from using container-interop to PSR-11. There were three container-interop **implementations**: - `Exception\NotFoundException` - `Symmetric\SymmetricPluginManager` - `Symmetric\PaddingPluginManager` These are all internal classes. The exception is thrown by the two plugin manager implementations, and those are straight-up `ContainerInterface` implementations. The classes that consume the plugin managers were checking for container-interop `ContainerInterface` implementations previously, but now check for PSR-11 versions, which is considered a type-widening operation, and thus backwards compatible. If we assume that the plugin managers are considered internal details, then this would be backwards compatible; if not, this is a BC break. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Since this package **provides** and **replaces** container-interop, this _should_ allow slip-streaming it in via a minor release without any BC breaks. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Ocramius
changed the title
container-interop/container-interop to psr/container in a backward compatible manner
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch switches from using container-interop as a dependency to using laminas-servicemanager 3.11.2+.
Internally, it also modifies all container-interop implementations to be psr/container implementations, and modifies type-checking to check against psr/container instead of container-interop.
Since laminas-servicemanager at those versions provides and replaces container-interop, this change is backwards compatible.
(This demonstration validates the approach.)
Fixes #20