Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ext-bcmath available by default for all php versions #213

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

Xerkus
Copy link
Member

@Xerkus Xerkus commented Jan 31, 2024

ext-bcmath is required by tools. apt install -y php-bcmath installs php8.3-bcmath which is not a default php version. Composer install for tools consequently fails. See #212

I think it would be appropriate to install the extension for all php versions rather than just the single version that happens to be used by tools.

Signed-off-by: Aleksei Khudiakov <[email protected]>
@boesing
Copy link
Member

boesing commented Jan 31, 2024

Afaik its only necessary for the bc Tool. that - on the other hand - is only executed on the container default php Version. So we just have to ensure it is available for the default version. for all other projects requiring the extension, the matrix is already pushing the requirement via job JSON which then installs the extension(s) on demand.

Yes, we can install and enable the extension for all PHP versions but its not a must-have.

Using php-bcmath was good enough until php 8.3 came out. using explicit php version for installing the default extension would be a fix for the referenced issue in OP.

@Xerkus
Copy link
Member Author

Xerkus commented Jan 31, 2024

It's not really about extensions that could be installed where needed. Ideally we would want to reduce any unnecessary differences between versions used in CI tasks. That is the reason I went with this approach instead of just changing to specific version for the tool installation.

@Xerkus Xerkus changed the base branch from 1.37.x to 1.38.x January 31, 2024 12:28
@Xerkus Xerkus added this to the 1.38 milestone Jan 31, 2024
@Xerkus Xerkus merged commit 925c3ba into laminas:1.38.x Jan 31, 2024
3 checks passed
@Xerkus Xerkus deleted the feature/bcmath-by-default branch January 31, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants