Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markdownlint also uses node so requires the latest versions #156

Merged

Conversation

internalsystemerror
Copy link
Member

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

After merging #155, #133 should have passed checks, however it appears that I missed the fact that markdownlint has its own docker stage.

This PR adds the nodesource repositories for the latest versions of node to the install-markdownlint stage also, in order to fix that.

@Ocramius Ocramius self-assigned this Jun 4, 2023
@Ocramius Ocramius added Enhancement dependencies Pull requests that update a dependency file labels Jun 4, 2023
@Ocramius
Copy link
Member

Ocramius commented Jun 4, 2023

Thanks @internalsystemerror!

@Ocramius Ocramius merged commit b7bc3ac into laminas:1.33.x Jun 4, 2023
@internalsystemerror internalsystemerror deleted the markdown-needs-node-too branch June 4, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants