qa: fix test suite to work with PHPUnit 9.5

Signed-off-by: Matthew Weier O'Phinney <[email protected]>

test/DeprecatedAssertionTrait.php

@@ -0,0 +1,30 @@
+<?php
+
+namespace LaminasTest\Config;
+
+use PHPUnit\Framework\TestCase;
+use ReflectionProperty;
+
+use function sprintf;
+
+trait DeprecatedAssertionTrait
+{
+    /** @param mixed $value */
+    public static function assertAttributeSame($value, string $property, object $instance, string $message = ''): void
+    {
+        $r = new ReflectionProperty($instance, $property);
+        $r->setAccessible(true);
+
+        if ($message === '') {
+            $message = sprintf(
+                'Failed asserting property %s::$%s with value %s matches value %s',
+                get_class($instance),
+                $property,
+                var_export($value, true),
+                var_export($r->getValue($instance), true)
+            );
+        }
+
+        TestCase::assertSame($value, $r->getValue($instance), $message);
+    }
+}

test/FactoryTest.php

@@ -9,6 +9,7 @@
 use Laminas\Config\StandaloneReaderPluginManager;
 use Laminas\Config\StandaloneWriterPluginManager;
 use Laminas\Config\WriterPluginManager;
+use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 use ReflectionProperty;
 use RuntimeException;
@@ -192,8 +193,9 @@ public function testFactoryCanRegisterCustomReaderInstance()
 
     public function testFactoryCanRegisterCustomReaderPlugin()
     {
-        $services      = $this->prophesize(ContainerInterface::class);
-        $pluginManager = new ReaderPluginManager($services->reveal(), ['services' => [
+        /** @var ContainerInterface&MockObject $services */
+        $services      = $this->createMock(ContainerInterface::class);
+        $pluginManager = new ReaderPluginManager($services, ['services' => [
             'DummyReader' => new Reader\TestAssets\DummyReader(),
         ]]);
         Factory::setReaderPluginManager($pluginManager);
@@ -208,13 +210,13 @@ public function testFactoryCanRegisterCustomReaderPlugin()
     public function testFactoryToFileInvalidFileExtension()
     {
         $this->expectException(RuntimeException::class);
-        $result = Factory::toFile(__DIR__.'/TestAssets/bad.ext', []);
+        Factory::toFile(__DIR__.'/TestAssets/bad.ext', []);
     }
 
     public function testFactoryToFileNoDirInHere()
     {
         $this->expectException(RuntimeException::class);
-        $result = Factory::toFile(__DIR__.'/TestAssets/NoDirInHere/nonExisiting/dummy.php', []);
+        Factory::toFile(__DIR__.'/TestAssets/NoDirInHere/nonExisiting/dummy.php', []);
     }
 
     public function testFactoryWriteToFile()
@@ -263,8 +265,9 @@ public function testFactoryCanRegisterCustomWriterInstance()
 
     public function testFactoryCanRegisterCustomWriterPlugin()
     {
-        $services = $this->prophesize(ContainerInterface::class);
-        $pluginManager = new WriterPluginManager($services->reveal(), ['services' => [
+        /** @var ContainerInterface&MockObject $services */
+        $services = $this->createMock(ContainerInterface::class);
+        $pluginManager = new WriterPluginManager($services, ['services' => [
             'DummyWriter' => new Writer\TestAssets\DummyWriter(),
         ]]);
         Factory::setWriterPluginManager($pluginManager);

test/Processor/ConstantTest.php

@@ -4,13 +4,16 @@
 
 use Laminas\Config\Config;
 use Laminas\Config\Processor\Constant as ConstantProcessor;
+use LaminasTest\Config\DeprecatedAssertionTrait;
 use PHPUnit\Framework\TestCase;
 
 use function define;
 use function defined;
 
 class ConstantTest extends TestCase
 {
+    use DeprecatedAssertionTrait;
+
     const CONFIG_TEST = 'config';
 
     public function constantProvider()

test/Processor/TokenTest.php

@@ -3,6 +3,7 @@
 namespace LaminasTest\Config\Processor;
 
 use Laminas\Config\Processor\Token as TokenProcessor;
+use LaminasTest\Config\DeprecatedAssertionTrait;
 use PHPUnit\Framework\TestCase;
 
 /**
@@ -11,6 +12,8 @@
  */
 class TokenTest extends TestCase
 {
+    use DeprecatedAssertionTrait;
+
     public function testKeyProcessingDisabledByDefault()
     {
         $processor = new TokenProcessor();

test/Reader/XmlTest.php

@@ -4,12 +4,9 @@
 
 use Laminas\Config\Exception;
 use Laminas\Config\Reader\Xml;
-use PHPUnit\Framework\Error\Warning;
 use ReflectionProperty;
-use ValueError;
 use XMLReader;
 
-use function class_exists;
 use function restore_error_handler;
 use function sys_get_temp_dir;
 
@@ -41,21 +38,6 @@ protected function getTestAssetPath($name)
         return __DIR__ . '/TestAssets/Xml/' . $name . '.xml';
     }
 
-    /**
-     * PHPUnit 5.7 does not namespace error classes; retrieve appropriate one
-     * based on what is available.
-     *
-     * @return string
-     */
-    protected function getExpectedWarningClass()
-    {
-        if (PHP_MAJOR_VERSION === 8) {
-            return ValueError::class;
-        }
-
-        return class_exists(Warning::class) ? Warning::class : \PHPUnit_Framework_Error_Warning::class;
-    }
-
     public function testInvalidXmlFile()
     {
         $this->reader = new Xml();
@@ -166,7 +148,7 @@ public function testCloseWhenCallFromFileReaderGetInvalid()
 
         $xmlReader = $this->getInternalXmlReader($configReader);
 
-        $this->expectException($this->getExpectedWarningClass());
+        $this->expectWarning();
 
         // following operation should fail because the internal reader is closed (and expected to be closed)
         $xmlReader->setParserProperty(XMLReader::VALIDATE, true);
@@ -194,7 +176,7 @@ public function testCloseWhenCallFromStringReaderGetInvalid()
 
         $xmlReader = $this->getInternalXmlReader($configReader);
 
-        $this->expectException($this->getExpectedWarningClass());
+        $this->expectWarning();
 
         // following operation should fail because the internal reader is closed (and expected to be closed)
         $xmlReader->setParserProperty(XMLReader::VALIDATE, true);