Add support for PHP 8.4 #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelaya
force-pushed
the
php-8.4-support
branch
from
31a1f0f to
e813d93
Compare
|
The workflow is red in PHP 8.4 with lowest dependencies, due to some deprecation warnings that make tests fail. The only way I have found to fix this is removing Do you think this is an acceptable approach? Otherwise I can continue poking with different dependency combinations to see if some pass with all PHP versions. |
|
@acelaya you may can try upgrade to latest phpunit "^10.5.38" |
Oh yeah, that works! I was almost sure I had tried that at one point 😅 |
acelaya
force-pushed
the
php-8.4-support
branch
2 times, most recently
from
29c98bb to
26a71e9
Compare
samsonasik
reviewed
Nov 17, 2024
Signed-off-by: Alejandro Celaya <[email protected]>
acelaya
force-pushed
the
php-8.4-support
branch
from
26a71e9 to
86bb27a
Compare
samsonasik
approved these changes
Nov 17, 2024
|
Thank you @acelaya |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings support for PHP 8.4 to this library.