Support for composer 2.3.0 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also re-enables tests for composer v1 which were dropped when migrating to PHP 8.1 Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
boesing
commented
Mar 16, 2022
Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
We do not need composer v1 to run tests on composer v1. We can install composer v1 as `require-dev` using composer v2. Afterwards, unit tests are able to detect composer v1 by applying the appropriate checks. Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
…uire` Signed-off-by: Maximilian Bösing <[email protected]>
…json` By adding an empty object to the config, we ensure that the default behavior of ignoring platform requirements for PHP 8 is disabled. Signed-off-by: Maximilian Bösing <[email protected]>
…us implementation Signed-off-by: Maximilian Bösing <[email protected]>
|
Can we kill composer v1 support, perhaps? :| |
|
I would prefer drop composer v1 when composer stops supporting it itself or when the maintenance amount gets too big. but as of now, maintaining v1 is not the problem. |
|
Ok, so I guess it's just about getting this build back to green then? I'm perfectly OK with keeping |
This also restores tests on older composer v2 versions Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
This resolves type incompatibilities with latest mocking changes. Signed-off-by: Maximilian Bösing <[email protected]>
Ocramius
requested changes
Mar 22, 2022
…n a string Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
Ocramius
requested changes
Mar 22, 2022
Signed-off-by: Maximilian Bösing <[email protected]>
|
Thanks @boesing - cutting a release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests are still failing due to composer/composer#10622
This also re-enables unit tests for composer v1 which were removed in v2.6.0