Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for PHP 8.1 #44
Add support for PHP 8.1 #44
Changes from 14 commits
221a2a6
c4e1deb
43046fe
e7d9369
156d646
9aa08e2
dc446b5
ad85090
efe1026
a7adba7
972fe4a
d43958d
b6b1afc
b7d3cb6
71f93ca
39af669
2d38612
6fc2ef5
8845f40
8ad7fdf
19d3a84
36d3ef7
f8c12e4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change introduce compatibility break, because changes public interface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see your point.
IIRC I discussed this with @boesing in chat. The
@param
type hint states parameter is of type string. If implementation is breaking, it is due to a misuse.Is that correct, @boesing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly,
__construct
has some special behavior if it comes to arguments. So this is actually no BC break until the type-hint matches what we do state in the@var
annotation.(sidenote: imho
laminas-component-installer
is not a library and thus, semver does not really make sense here at all. But actually, we do not differ between libraries and components like this (composer plugin))There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fun-fact: this constructor argument is only added for unit tests so we can pass virtual filesystem directory