Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-variadic parameter should not throw exception when calling ParameterGenerator#setVariadic(false) with an existing default value #173

Merged
merged 5 commits into from
Mar 4, 2023
Merged

Non-variadic parameter should not throw exception when calling ParameterGenerator#setVariadic(false) with an existing default value #173

merged 5 commits into from
Mar 4, 2023

Commits on Mar 3, 2023

  1. Update ParameterGenerator.php 

    setVariadic should only throw exception when parameter is variadic and has default value.

Signed-off-by: sakhunzai <[email protected]>
    @sakhunzai
    sakhunzai authored Mar 3, 2023
    Configuration menu
    Copy the full SHA
    f3bca9a View commit details
    Browse the repository at this point in the history

  2. Update ParameterGeneratorTest.php 

    Non variadic parameter should not throw exception when having default value

Signed-off-by: sakhunzai <[email protected]>
    @sakhunzai
    sakhunzai authored Mar 3, 2023
    Configuration menu
    Copy the full SHA
    538565f View commit details
    Browse the repository at this point in the history

  3. Update ParameterGenerator.php 

    remote whitespaces

Signed-off-by: sakhunzai <[email protected]>
    @sakhunzai
    sakhunzai authored Mar 3, 2023
    Configuration menu
    Copy the full SHA
    6669044 View commit details
    Browse the repository at this point in the history

  4. Update ParameterGeneratorTest.php 

    remote whitespaces

Signed-off-by: sakhunzai <[email protected]>
    @sakhunzai
    sakhunzai authored Mar 3, 2023
    Configuration menu
    Copy the full SHA
    3961d7a View commit details
    Browse the repository at this point in the history

  5. Update ParameterGeneratorTest.php 

    added  generated code expectation

Signed-off-by: sakhunzai <[email protected]>
    @sakhunzai
    sakhunzai authored Mar 3, 2023
    Configuration menu
    Copy the full SHA
    0896096 View commit details
    Browse the repository at this point in the history