Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update composer.json #48

Closed
wants to merge 7 commits into from
Closed

Update composer.json #48

wants to merge 7 commits into from

Conversation

gildonei
Copy link
Contributor

@gildonei gildonei commented Feb 7, 2022

Q A
Bugfix yes

Description

Fixed post-create-project-cmd for windows by replacing single quotes for double quotes

Testing in Win 11 / php 7.4.9 cli using git clone / composer install

composer.json Outdated Show resolved Hide resolved
@Ocramius Ocramius added Awaiting Author Updates Bug Something isn't working labels Feb 7, 2022
Single quoted file checks and unlink
Copy link
Contributor Author

@gildonei gildonei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could I also incluide a new line in .gitignore in this PR? (VSCode .history/*)

@froschdesign
Copy link
Member

@gildonei

Could I also incluide a new line in .gitignore in this PR? (VSCode .history/*)

There is no need to extend the .gitignore file of this repository, this can be done via a global .gitignore file or via an exclude rule.

@froschdesign
Copy link
Member

It looks like this solution can also be added to laminas-mvc-skeleton: laminas/laminas-mvc-skeleton#42

Copy link
Contributor Author

@gildonei gildonei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated modules.config.php from master
Updated composer.lock from master
Fixed composer.json post-create-project-cmd for windows

Signed-off-by: Gildonei [email protected]

Signed-off-by: Gildonei M A Junior <[email protected]>
@gildonei gildonei requested a review from Ocramius February 8, 2022 11:58
@gildonei gildonei closed this Feb 8, 2022
@gildonei
Copy link
Contributor Author

gildonei commented Feb 8, 2022

I gave up
Signed-off-by: Gildonei M A Junior [email protected]

@gildonei gildonei reopened this Feb 8, 2022
…ues from composer update

Signed-off-by: Gildonei M A Junior <[email protected]>
@gildonei
Copy link
Contributor Author

gildonei commented Feb 8, 2022

Hello @Ocramius can you give a help how to pass those conflicts?

Copy link
Contributor Author

@gildonei gildonei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Gildonei M A Junior [email protected]

Copy link
Contributor Author

@gildonei gildonei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Gildonei M A Junior [email protected]

Copy link
Contributor Author

@gildonei gildonei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Gildonei M A Junior [email protected]

Copy link
Contributor Author

@gildonei gildonei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Gildonei M A Junior [email protected]

@gildonei gildonei closed this Feb 8, 2022
@Ocramius
Copy link
Member

Ocramius commented Feb 8, 2022

Was this supposed to be closed?

@gildonei
Copy link
Contributor Author

gildonei commented Feb 8, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Author Updates Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants