Issue rust-lang#50974: Suboptimal error in case of duplicate , in s…

…truct constructor
lambtowolf · Jun 22, 2018 · 7969b78 · 7969b78
1 parent 7dae5c0
commit 7969b78
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src/libsyntax/parse/parser.rs b/src/libsyntax/parse/parser.rs
@@ -776,6 +776,9 @@ impl<'a> Parser<'a> {
             err.span_label(self.span, format!("expected identifier, found {}", token_descr));
         } else {
             err.span_label(self.span, "expected identifier");
+            if self.token == token::Comma {
+                err.span_suggestion(self.span, "try removing a comma", ",".into());
+            }
         }
         err
     }
@@ -2446,8 +2449,11 @@ impl<'a> Parser<'a> {
                 Err(mut e) => {
                     e.span_label(struct_sp, "while parsing this struct");
                     e.emit();
-                    self.recover_stmt();
-                    break;
+
+                    if self.token != token::Comma {
+                        self.recover_stmt();
+                        break;
+                    }
                 }
             }