Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add :old-group-id support #9

Closed
plexus opened this issue May 31, 2022 · 1 comment
Closed

Add :old-group-id support #9

plexus opened this issue May 31, 2022 · 1 comment

Comments

@plexus
Copy link
Member

plexus commented May 31, 2022

Currently in bin/proj we set the Maven group-id, e.g. here is the bin/proj for Facai

#!/usr/bin/env bb
(ns proj
  (:require [lioss.main :as lioss]))

(lioss/main
 {:license                  :mpl
  :inception-year           2022
  :description              "The ultimate factory library"
  :group-id                 "com.lambdaisland"
  :version-qualifier        "alpha"
  :aliases-as-optional-deps [:jdbc]})

As explained in #2 , we have a few projects that have previously been released under lambdaisland, where at some point we switched to com.lambdaisland. For these we want to still release a version under lambdaisland, but one that is nothing but an empty jar (only containing the pom), with a single dependency on the com.lambdaisland version. We'll specify this through a new option in bin/proj: :old-group-id.

:group-id "com.lambdaisland"
:old-group-id "lambdaisland"

If this key is present the release process (see lioss.release/do-release), after deploying the main artifact, will create a pom.xml in a temp directory, and then mvn deploy it from there.

We'll need to implement the single-dependency-pom, see lioss.pom/regular-pom and lioss.pom/relocation-pom. This new pom will not have a relocation stanza (we're not actually using Maven relocation support), it will have a <dependencies> section pointing at the previously released artifact.

@plexus
Copy link
Member Author

plexus commented Nov 25, 2022

@kamilwaheed did a good job on this, we're using this for releases of kaocha-cljs.

@plexus plexus closed this as completed Nov 25, 2022
plexus added a commit to lambdaisland/glogi that referenced this issue Nov 25, 2022
## Added

- Add support for logging multiple forms with `spy`.

## Fixed

- Release under `com.lambdaisland` as well as `lambdaisland`, see lambdaisland/open-source#9

## Changed

- Version bumps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant