Properly handle unknown load-config source

lambdaisland · Apr 13, 2022 · 3c8484c · 3c8484c
1 parent f21454b
commit 3c8484c
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/src/kaocha/config.clj b/src/kaocha/config.clj
@@ -115,9 +115,9 @@
 
 (extend-protocol ConfigSource
 
-  nil ;; handle nil source case
-  (read-config [_ _]
-   (default-config))
+  Object ;; keep existing default behaviour
+  (read-config [path opts]
+    (read-config (io/file path) opts))
 
   File
   (read-config [^File file opts]
@@ -127,10 +127,6 @@
      ;; and will only revert to a file if not
      (read-config-source file opts)))
 
-  String ;; keep existing default behaviour
-  (read-config [path opts]
-   (read-config (io/file path) opts))
-
   URL ;; resource
   (read-config [resource opts]
    (when resource
@@ -148,7 +144,7 @@
   ([source opts]
    (if-some [config (read-config source opts)]
      config
-     (read-config nil opts))))
+     (default-config))))
 
 (defn apply-cli-opts [config options]
   (cond-> config