Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove ecPairing outdated TODOs #231

Merged
merged 6 commits into from
Feb 29, 2024
Merged

fix: Remove ecPairing outdated TODOs #231

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b2e0435
Squashed '.test-node-subtree/' changes from fb635d1..814ae72
ColoCarletti Feb 29, 2024
757cf9f
Merge commit 'b2e0435dfed5a8dad457f1fc2b469c28926010a1'
ColoCarletti Feb 29, 2024
14afb83
remove outdated TODOs
ColoCarletti Feb 29, 2024
7759b89
Merge branch 'main' of github.com:lambdaclass/zksync_era_precompiles
ColoCarletti Feb 29, 2024
e579bd9
Merge branch 'main' into fix/remove-ecPairing-outdated-TODOs
ColoCarletti Feb 29, 2024
ee2c4b7
remove whitespace
ColoCarletti Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions precompiles/EcPairing.yul
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1614,12 +1614,10 @@ object "EcPairing" {
let g2_y1 := mload(g2_y1_offset)
let g2_y0 := mload(g2_y0_offset)

// TODO: Double check if this is right
if iszero(and(coordinateIsOnFieldOrder(g2_x0), coordinateIsOnFieldOrder(g2_x1))) {
burnGas()
}

// TODO: Double check if this is right
if iszero(and(coordinateIsOnFieldOrder(g2_y0), coordinateIsOnFieldOrder(g2_y1))) {
burnGas()
}
Expand Down
Loading