Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eip712 rlp encoding fix #132

Merged
merged 2 commits into from
Sep 10, 2024
Merged

fix: eip712 rlp encoding fix #132

merged 2 commits into from
Sep 10, 2024

Conversation

ischasny
Copy link
Contributor

@ischasny ischasny commented Sep 9, 2024

Update Paymaster Params and its rlp encoding to be inline with zksync-era

@IAvecilla
Copy link
Contributor

@ischasny Looks good!
Could we apply the formatter and also remove the unused imports in the paymaster_params.rs file? It's not necessary for the lint job in the CI to pass, as there are other unrelated issues to fix.

@ischasny
Copy link
Contributor Author

@ischasny Looks good! Could we apply the formatter and also remove the unused imports in the paymaster_params.rs file? It's not necessary for the lint job in the CI to pass, as there are other unrelated issues to fix.

Hi @IAvecilla - thank you for review, done!

@IAvecilla IAvecilla enabled auto-merge (squash) September 10, 2024 13:18
@IAvecilla IAvecilla merged commit 39008d8 into lambdaclass:main Sep 10, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants