feat(WIP): Native ERC20 #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Make zk script compile unconditionally
* re-add weth step in zk init * add correct commit hash in contracts submodule --------- Co-authored-by: Santiago Pittella <[email protected]>
* re-add weth step in zk init * add correct commit hash in contracts submodule * uncomment steps from init * update contracts submodule commit --------- Co-authored-by: Santiago Pittella <[email protected]>
* store native token json in etc/tokens/ * fmt --------- Co-authored-by: Santiago Pittella <[email protected]>
* add methods * fmt * add impl * improve error handling
* Add tool versions for nodejs * Working ERC20 fetcher draft * Move code to separate file * Replace gas price with erc-20 value * Rename variable * zk fmt * Add tool versions for nodejs * Gas Price RPC changes * Temporarily remove some debug statements for clearer logs * Add conversion rate RPC endpoint * initial commit * add withdrawal tests * remove sleeps * tighten withdraw test --------- Co-authored-by: Francisco Krause Arnim <[email protected]> Co-authored-by: Jmunoz <[email protected]>
* set native token env * rmv try-catch
jrchatruc
force-pushed
the
native_erc20
branch
from
b590b01 to
4dc12d8
Compare
* Add tool versions for nodejs * Working ERC20 fetcher draft * Move code to separate file * Replace gas price with erc-20 value * Rename variable * zk fmt * Add tool versions for nodejs * Gas Price RPC changes * Temporarily remove some debug statements for clearer logs * Add conversion rate RPC endpoint * initial commit * add deposit test file * fmt * update test * Add test for not enough balance case * add test for failing case * remove native-erc20.test.ts file --------- Co-authored-by: Francisco Krause Arnim <[email protected]> Co-authored-by: Jmunoz <[email protected]> Co-authored-by: Santiago Pittella <[email protected]> Co-authored-by: Santiago Pittella <[email protected]> Co-authored-by: Santiago Pittella <[email protected]>
* change contracts submodule * remove test context restrictions * deposit eth in context owner * add non native token integration test * apply fmt * update contracts submodule * wip in tests * update contracts submodule * try different l2 addresses * fix deployL2 * update contracts submodule * fix l2 weth token init * try different l2 addresses * add l2bridge query * update contracts submodule * wip * clean up * add nonNative tokens for testing, remove l2gasLimit from test * Pass native erc20 flag to preprocessor * zk fmt * fix missing msg.value to amount * update submodule * update submodule * Update submodule --------- Co-authored-by: Santiago Pittella <[email protected]> Co-authored-by: Javier Chatruc <[email protected]> Co-authored-by: Santiago Pittella <[email protected]>
… case or the native eth case
* fix: fix withdraw tests * chore: zk fmt * feat: add final check of balance for withdraw test * Fix tests --------- Co-authored-by: Javier Chatruc <[email protected]>
…with eth base token (#148) * feat: rename native (base) token address endpoint * feat: use 0x...1 when eth is the base token * chore: cargo fmt
* feat: rename native (base) token address endpoint * feat: use 0x...1 when eth is the base token * chore: cargo fmt * feat: avoid using env var for testing native erc20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Replace Ether as the native currency for an ERC20 already available in L1 for a ZK Stack based chain
Why ❔
Checklist
zk fmtandzk lint.