feat: Validium mode + Fee Model V2 #66
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oppen
reviewed
Jan 31, 2024
Comment on lines
67
to
75
| FeeModelConfig::V2(config) => { | ||
| let validium_mode = std::env::var("VALIDIUM_MODE") == Ok("true".to_owned()); | ||
| FeeParams::V2(FeeParamsV2 { | ||
| config, | ||
| l1_gas_price: self.provider.estimate_effective_gas_price(), | ||
| l1_pubdata_price: self.provider.estimate_effective_pubdata_price() | ||
| * !validium_mode as u64, | ||
| }) | ||
| } |
There was a problem hiding this comment.
This can be left untouched. The provider's estimate_effective_pubdata_price should return 0 instead in validium mode.
There was a problem hiding this comment.
IIRC that's a configuration flag in chain.toml.
Oppen
reviewed
Jan 31, 2024
| Once the server is running, run this command in other terminal: | ||
|
|
||
| ```sh | ||
| cargo run --release --bin zksync_full_stack |
There was a problem hiding this comment.
This is outdated I think. Shouldn't this be the example now?
* add variable to .toml * zk fmt
…m_mode_new_fee_model_final
…class/zksync-era into validium_mode_new_fee_model_final
Oppen
pushed a commit
that referenced
this pull request
Feb 9, 2024
Co-authored-by: Lyova Potyomkin <[email protected]>
Oppen
pushed a commit
that referenced
this pull request
Feb 9, 2024
…bel-external-contributions ci: add workflow to label external-contributions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR merges the Validium mode that is working with the old fee model with the feature of the new fee model.
Changes
The commits are self-explanatory, so I'll list them and briefly describe what has been made on them.
era-contractsandzksync_serveruse.VALIDIUM_MODEenv set by theinit.tsstep.chain.tomlfile but one, this isl1_pubdata_price, which when set to 0 gives a huge gas use improvement in addition to the said config (yes, said config impacts the gas used by its own, settingl1_pubdata_priceto 0 lowers more the gas usage).Testing scenario
For comparing results between Rollup and Validium mode we are running the
validium_mode_examplebinary with the system initialized both withzk initandzk init --validium-modeand running the server withzk server.The
validium_mode_examplebinary deposits some ETH to an account which will be used to deploy an ERC20 contract that is going to be called twice, for minting and transferring. For every mentioned action, some useful data like the transaction hash gas used will be printed to the stdout for later analysis.In parallel, we are also using a debugging tool developed by Marcin that displays batch info. It is very useful to see data like L2 -> L1 messages, Large L2 -> L1 messages, Published bytecodes, and writes to the storage. As a TLDR, it is a server from which you can query batches by number and analyze said data. It's easy to know in which batch a transaction has been added with the
eth_getTransactionByHashmethod.In the section below you'll find a step-by-step guide to run said test scenario and see the results by yourself
Step-by-step
For running the example in Rollup mode
zk && zk clean --all && zk initto initialize the system in Rollup mode in a clear environment.zk serverto run the server in one console.cargo run --release --bin validium_mode_exampleto run the Validium mode example in another console.cdinto it.python3 operator/app.py.http://127.0.0.1:5000in your browser./batch/<batch_number>For running the example in Validium mode
zk && zk clean --all && zk init --validium-modeto initialize the system in Validium mode in a clear environment.zk serverto run the server in one console.cargo run --release --bin validium_mode_exampleto run the Validium mode example in another console.cdinto it.python3 operator/app.py.http://127.0.0.1:5000in your browser./batch/<batch_number>Results
Config:
max_pubdata_per_batchpubdata_overhead_partcompute_overhead_partbatch_overhead_l1_gasinternal_enforced_l1_gas_price