feat(eigen-client-extra-features): Move inclusion logic #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juan518munoz
approved these changes
Nov 26, 2024
juanbono
reviewed
Nov 28, 2024
| @@ -32,6 +32,11 @@ impl EigenClient { | |||
| client: Arc::new(client), | |||
| }) | |||
| } | |||
|
|
|||
| pub async fn get_commitment(&self, blob_id: &str) -> anyhow::Result<String> { | |||
juanbono
reviewed
Nov 28, 2024
|
|
||
| // 5. poll for blob status until it reaches the Confirmed state | ||
| pub async fn get_inclusion_data(&self, blob_id: &str) -> anyhow::Result<String> { |
juanbono
approved these changes
Nov 28, 2024
gianbelinche
merged commit 01b50ed
into
eigen-client-extra-features
15 of 28 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This PR moves inclusion and verify logic from disperse blob to get inclusion data
Why ❔
Checklist
zkstack dev fmtandzkstack dev lint.