feat(eigen-client-m0-implementation): send blob id to l1 #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_all_blobs/src/main.rs
Outdated
| let latest_block = provider.get_block_number().await?; | ||
| let mut json_array = Vec::new(); | ||
|
|
||
| for block_number in 0..=latest_block { |
There was a problem hiding this comment.
For holesky testing we should not start at 0 or it will take too long, maybe this could be a parameter
get_all_blobs/src/main.rs
Outdated
Comment on lines
122
to
125
| let validator_timelock_address = | ||
| Address::from_str("0x95af79aAB990f9740c029013ef18f3D3d666B4e8")?; | ||
| let commit_batches_selector = "6edd4f12"; | ||
|
|
There was a problem hiding this comment.
The validator_timelock_address is different each init, so it should be a parameter, the function selector usually does not change, so it is fine.
We should also add the url as parameter, for testing on holesky
|
We should add steps on how to run the get all blobs on the Readme |
get_all_blobs/Cargo.toml
Outdated
There was a problem hiding this comment.
Does it needs all those workspaces? Specially the zksync one, since it makes the compile time longer
get_all_blobs/src/main.rs
Outdated
Comment on lines
97
to
99
| let pubdata_commitments = commit_batch_info.last().ok_or(anyhow::anyhow!( | ||
| "pubdata_commitments not found in commitBatchesSharedBridge input" | ||
| ))?; |
There was a problem hiding this comment.
Instead of taking the last, we should loop it and for each one decode a blob info and push it to the json
juanbono
reviewed
Nov 11, 2024
get_all_blobs/src/main.rs
Outdated
|
|
||
| let validator_timelock_address = Address::from_str(&args[1])?; | ||
|
|
||
| let commit_batches_selector = "6edd4f12"; |
juanbono
reviewed
Nov 11, 2024
get_all_blobs/src/main.rs
Outdated
| } | ||
|
|
||
| async fn decode_blob_data_input(input: &[u8]) -> anyhow::Result<Vec<BlobData>> { | ||
| let path = "./abi/commitBatchesSharedBridge.json"; |
juanbono
approved these changes
Nov 12, 2024
10 tasks
juan518munoz
merged commit 5e3b125
into
eigen-client-m0-implementation
6 of 9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Send Eigend DA blob id to L1, in order to persist it and be able to rebuild the chain from it.
Checklist
zkstack dev fmtandzkstack dev lint.