Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: don't charge for pubdata in Validium mode #32
feat: don't charge for pubdata in Validium mode #32
Changes from 18 commits
c944c92
837cf6f
181d80c
cb7edd8
714bd35
3f91e20
c3373d2
ce4de82
cc32b58
f8edfa4
27ab211
240c0a8
c683f9a
4699ae9
215b9d9
5d3d96c
c71ff9c
183957d
cff8bfd
5bbeb3c
aad41bb
64e639a
557ec52
b9ceb92
3aa9f50
479061d
ef48b51
5c3dfc5
55d04f3
48a90a0
5e98b84
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debugging statements obviously should not be present in the code that is to be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course, there will be a clean PR to your repo when finished
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, we'll remove this rn cause is not useful anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VM should have no assumptions regarding available environment variables.
In general, the only source of environment variables right now is the
zksync_env_config
crate.In the future, we'll have different configuration schemas not based on the env variables (think JSON configs), so you should present configuration in an explicit and serialization-agnostic form.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.