forked from matter-labs/zksync-era
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multivm tests for era_vm
#234
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
juan518munoz
approved these changes
Aug 16, 2024
MarcosNicolau
changed the title
Add basic test setup for era_vm
Multivm tests for Aug 20, 2024
era_vm
This pr has grown and now should include the fixes for all remaining tests. The following changes have been made to the era_vm bootloader:
This make all tests pass except for:
I believe these tests have little to do with the bootloader, I think we are doing something wrong on the |
The compressor contract that gets called, expects the storage_diff to be sorted in a particular way. This fixes all remaining tests
fkrause98
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This pr makes the necessary changes to test the era_vm integration with the bootloader:
To run the tests do:
cargo test era_vm
undercore/lib/multivm
. You should see:This pr depends on the adaptation on
era_vm
, see here.Checklist
zk fmt
andzk lint
.