feat(Polynomial Commitments): Abstract PCS interface and Add Zeromorph PCS #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatStiles
force-pushed
the
feat/zeromorph
branch
from
fa9db2f
to
d6e353e
Compare
PatStiles
changed the title
| let g1 = P::G1Point::neutral_element().operate_with_self(g1_scalar.representative()); | ||
| rng.fill_bytes(&mut bytes); | ||
| let g2_scalar = FieldElement::<P::BaseField>::from_bytes_be(&bytes).unwrap(); | ||
| let g2 = P::G2Point::neutral_element().operate_with_self(g2_scalar.representative()); |
There was a problem hiding this comment.
This operation returns the neutral_element(). Shouldn't this be generator()?
PatStiles
force-pushed
the
feat/zeromorph
branch
from
1768c80
to
2f3b6f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Zeromorph PCS
Description
Refactors IsCommitmentScheme to be more generic and accepting of different PCS schemes.
Modifies KZG commitments and the Plonk prover to accomodate said interface
Adds a non-hiding version of the Zeromorph Multilinear PCS scheme for batched and unbatched commitments to a series of multilinear polynomials. Builds off a Feat(poly): Add Dense and Sparse Multilinear Polynomials #726 .
Type of change
Please delete options that are not relevant.
Checklist