Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LEVM: (EF Tests) EIP5656 MCOPY #749

Closed
Tracked by #1204
iinaki opened this issue Oct 8, 2024 · 0 comments · Fixed by #825
Closed
Tracked by #1204

LEVM: (EF Tests) EIP5656 MCOPY #749

iinaki opened this issue Oct 8, 2024 · 0 comments · Fixed by #825

Comments

@iinaki
Copy link
Contributor

iinaki commented Oct 8, 2024

To remove from ignored this suites:

  • "stEIP5656-MCOPY".into(),
  • "eip5656_mcopy".into(),
This was referenced Oct 8, 2024
Open
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 15, 2024
@iinaki
feat(levm): ef tests from eip5656: MCOPY (#825)
a7f5d8e 
**Motivation**
This [EIP](https://eips.ethereum.org/EIPS/eip-5656) introduces the
`MCOPY` instruction.

The tests failed because we were letting them to overflow in some
arithmetic operations, this caused the memory expansion to not be
handled correctly, as it could panic.

**Changes**

- To remove from ignored this suites:
    - "stEIP5656-MCOPY".into(),
    - "eip5656_mcopy".into(),
- Added checks to those arithmetic ops that overflowed.

**Description**

<!-- A clear and concise general description of the changes this PR
introduces -->

Closes #749
@ilitteri ilitteri mentioned this issue Nov 19, 2024
Open
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
ethereum_rust
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(levm): ef tests from eip5656: MCOPY lambdaclass/ethrex
1 participant
@iinaki