Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eigen-client-m1): Add dummy bridge #41

Open
wants to merge 8 commits into
base: eigen-client-m1
Choose a base branch
from

Conversation

gianbelinche
Copy link

What ❔

This PR adds EigenDA connection to the to be implemented bridge, with a dummy bridge that accepts all batches
Related to: lambdaclass/zksync-era#381

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

import {DummyVectorX} from "./DummyVectorX.sol";

contract DummyEigenDABridge is IEigenDABridge {
IVectorx public vectorxContract;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't call it vectorx since it will not use it

vectorxContract = new DummyVectorX();
}

function vectorx() external view returns (IVectorx) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here


pragma solidity 0.8.24;

import {IVectorx} from "./IVectorx.sol";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link

@juanbono juanbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is wrong to use vectorx since that will not be used.

@gianbelinche
Copy link
Author

@juanbono done!

Base automatically changed from eigen-client-m1-add-validators to eigen-client-m1 January 6, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants