feat: Validium mode #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilitteri
changed the base branch from
validium_mode
to
zksync-era-contracts-commit
Oppen
reviewed
Jan 31, 2024
| require(logSender == L2_TO_L1_MESSENGER_SYSTEM_CONTRACT_ADDR, "ln"); | ||
| require(providedL2ToL1PubdataHash == logValue, "wp"); | ||
| // #endif |
There was a problem hiding this comment.
Given we made it a "real" Solidity constant, maybe we can use a regular if instead of solpp here?
There was a problem hiding this comment.
Good point, I'll try it
There was a problem hiding this comment.
In fact, I'm not 100% sure the special case is even necessary. Shouldn't we just not expect the key to be present, and thus this case be dead code for validium?
…te_validium_mode_contracts
mationorato
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.