Skip to content
Back to pull request #25

Update solc version for system contracts #47

Sign in to view logs

Update solc version for system contracts

Update solc version for system contracts #47

Triggered via pull request August 12, 2024 18:41
@IAvecillaIAvecilla
synchronize #25
update_solidity_version
Status Failure
Total duration 5m 9s
Artifacts –

system-contracts-ci.yaml

on: pull_request
build
4m 9s
build
lint
53s
lint
check-hashes
38s
check-hashes
test-bootloader
0s
test-bootloader
test-contracts
0s
test-contracts
Fit to window
Zoom out
Zoom in

Annotations

11 errors and 4 warnings
lint: l1-contracts/contracts/governance/ChainAdmin.sol#L26
Error message for require is too long: 40 counted / 32 allowed
lint: l1-contracts/contracts/governance/ChainAdmin.sol#L26
GC: Use Custom Errors instead of require statements
lint: l1-contracts/contracts/governance/ChainAdmin.sol#L53
GC: Use Custom Errors instead of require statements
lint: l1-contracts/contracts/governance/ChainAdmin.sol#L54
GC: Found [ .length ] property in Loop condition. Suggestion: assign it to a variable
lint: l1-contracts/contracts/governance/ChainAdmin.sol#L72
Error message for require is too long: 55 counted / 32 allowed
lint: l1-contracts/contracts/governance/ChainAdmin.sol#L72
GC: Use Custom Errors instead of require statements
lint: l1-contracts/deploy-scripts/DecentralizeGovernanceUpgradeScript.s.sol#L20
Provide an error message for require
lint: l1-contracts/deploy-scripts/DecentralizeGovernanceUpgradeScript.s.sol#L20
GC: Use Custom Errors instead of require statements
lint: l1-contracts/deploy-scripts/DecentralizeGovernanceUpgradeScript.s.sol#L21
Provide an error message for require
lint: l1-contracts/deploy-scripts/DecentralizeGovernanceUpgradeScript.s.sol#L21
GC: Use Custom Errors instead of require statements
check-hashes
Process completed with exit code 1.
lint
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
lint: system-contracts/contracts/ContractDeployer.sol#L192
Avoid to use tx.origin
build
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-node@v3, actions/cache/save@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
check-hashes
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-node@v3, actions/cache/restore@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/