Correct docs moving and add example from source code #73
Conversation
| $ flameshow goroutine.out | ||
| ``` | ||
|
|
||
| After entering the TUI, the available actions are listed on Footer: | ||
|
|
||
| - <kbd>q</kbd> for quit | ||
| - <kbd>j</kbd> <kbd>i</kbd> <kbd>j</kbd> <kbd>k</kbd> or <kbd>←</kbd> |
There was a problem hiding this comment.
wrong moving key here
README.md
Outdated
| @@ -40,14 +40,14 @@ nix profile install github:laixintao/flameshow | |||
| View golang's goroutine dump: | |||
|
|
|||
| ```shell | |||
| $ curl http://localhost:9100/debug/pprof/goroutine -o goroutine.out | |||
| $ curl https://raw.githubusercontent.com/laixintao/flameshow/main/tests/pprof_data/goroutine.out -o goroutine.out | |||
There was a problem hiding this comment.
provide exists file in test dir for users get start quickly
There was a problem hiding this comment.
I prefer not changing this line.
The code is for showing user how to view golang's pprof data. User will understand /debug/pprof/goroutine is a pprof format.
There was a problem hiding this comment.
Got it and revert the change
|
Thank you |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
=======================================
Coverage 94.34% 94.34%
=======================================
Files 17 17
Lines 1185 1185
=======================================
Hits 1118 1118
Misses 67 67 ☔ View full report in Codecov by Sentry. |
|
BTW, ci fail seems we do not pin black version, should I approve the change for latest version of black in this PR, or something else? |
|
merged, thanks. And yes, black should be pinned. |
No description provided.