Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump protobuf 4.24.4 -> 4.25.2 #72

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

bobrik
Copy link
Contributor

@bobrik bobrik commented Jan 15, 2024

This allows building the nix flake on aarch64-darwin:

I bumped the version in pyproject.yaml and ran poetry lock --no-update.

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1886962) 94.34% compared to head (14c59a6) 94.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #72   +/-   ##
=======================================
  Coverage   94.34%   94.34%           
=======================================
  Files          17       17           
  Lines        1185     1185           
=======================================
  Hits         1118     1118           
  Misses         67       67           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ironically, poetry doesn't build on nix:

/private/tmp/nix-build-python3.11-poetry-1.7.1.drv-0/source
Finished executing pypaBuildPhase
@nix { "action": "setPhase", "phase": "pythonRuntimeDepsCheckHook" }
Running phase: pythonRuntimeDepsCheckHook
Executing pythonRuntimeDepsCheck
Checking runtime dependencies for poetry-1.7.1-py3-none-any.whl
  - xattr<0.11.0,>=0.10.0 not satisfied by version 1.0.0

I ran it from Debian Bookworm with Poetry (version 1.3.2).

This allows building the nix flake on aarch64-darwin:

* protocolbuffers/upb#1492

I bumped the version in `pyproject.yaml` and ran `poetry lock --no-update`.
@laixintao laixintao merged commit cdbac05 into laixintao:main Jan 18, 2024
9 checks passed
@laixintao
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants