Fix Sprite unit test undefined behavior (gmock)
#1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `EXPECT_CALL` has an implicit `Times(1)`, so the second `EXPECT_CALL` with `Times(0)` is redundant.
By removing the loop we also remove the `EXPECT_CALL` uses after a call has already been made to the mock. This is required to avoid undefined behavior. The middle cases are less interesting, so we only preserve the boundary cases. Whether we use a time delta of 0, or one large enough to cycle through two stop frames, there should only ever be exactly one call to the handler. This is true even if the `advanceByTimeDelta` function is called a second time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of:
Split of unit tests so only one
EXPECT_CALLis needed per test, and it is before any calls to the mock handler.