Add .exe suffix to executable Windows targets
#1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ideally the output filenames should match platform expectations. Normally the `.exe` suffix would be added anyway. Though the `makefile` rules reference the output filenames in a few places. Mostly the `.exe` suffix can be inferred. However, it is better for output names to match exactly, especially for `makefile` rules that need to determine if an output file is up-to-date. Additionally, it was noted while looking into Wine upgrades that starting with Wine version 7, there seems to be trouble starting executable files when the `.exe` suffix is not explicitly specified. Failure to specify it can result in a hard to understand error message with code `c0000135` (`STATUS_DLL_NOT_FOUND` defined in `ntstatus.h`): > wine: failed to open "../.build/Debug_Linux_test/test": c0000135 The same command works when the file to run is given an explicit suffix when passed to `wine`: > "../.build/Debug_Linux_test/test.exe"
DanRStevens
added a commit
that referenced
this pull request
Dec 30, 2024
This version of Wine requires an explicit `.exe` suffix on the executable names when opening them with `wine`. Without the suffix, loading fails with error `c0000135` (`STATUS_DLL_NOT_FOUND`), which is defined in `ntstatus.h`. For details, see PR #1181.
DanRStevens
added a commit
that referenced
this pull request
Jan 1, 2025
This version of Wine requires an explicit `.exe` suffix on the executable names when opening them with `wine`. Without the suffix, loading fails with error `c0000135` (`STATUS_DLL_NOT_FOUND`), which is defined in `ntstatus.h`. For details, see PR #1181.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally the output filenames should match platform expectations. Normally the
.exesuffix would be added anyway. Though themakefilerules reference the output filenames in a few places. Mostly the.exesuffix can be inferred. However, it is better for output names to match exactly, especially formakefilerules that need to determine if an output file is up-to-date.Additionally, it was noted while looking into Wine upgrades that starting with Wine version 7, there seems to be trouble starting executable files when the
.exesuffix is not explicitly specified. Failure to specify it can result in a hard to understand error message with codec0000135(STATUS_DLL_NOT_FOUNDdefined inntstatus.h):The same command works when the file to run is given an explicit suffix when passed to
wine:Relates to: