Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

References new Kubernetes / OpenShift deployment guide #1785

Merged
merged 6 commits into from
Mar 14, 2019

Conversation

octonato
Copy link
Member

No description provided.

docs/manual/java/releases/Migration15.md Outdated Show resolved Hide resolved
docs/manual/java/releases/Migration15.md Outdated Show resolved Hide resolved
docs/manual/scala/releases/Migration15.md Outdated Show resolved Hide resolved
docs/manual/scala/releases/Migration15.md Outdated Show resolved Hide resolved
docs/manual/scala/releases/Migration15.md Show resolved Hide resolved
@@ -114,11 +114,11 @@ akka {

#### Docker images and deployment specs

With the removal of ConductR or Lightbend Orchestration, the docker images and deployment specs will have to be maintained manually. Therefore the recommended migration is to take ownership of the `Dockerfile`, deployment scripts and orchestration specs created by such tooling, such as by committing them to the source repository and then maintaining them. We also found that such maintenance can be made easier by making use of [kustomize](https://github.com/kubernetes-sigs/kustomize).
With the removal of ConductR or Lightbend Orchestration, the docker images and deployment specs will have to be maintained manually. Therefore the recommended migration is to take ownership of the `Dockerfile`, deployment scripts and orchestration specs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a small explanation about why do we consider this a better approach for users?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add here the same text I used on a recent discussion at http://discuss.lightbend.com/

Copy link
Contributor

@ignasi35 ignasi35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add to what @marcospereira already mentioned.


```scala
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

marcospereira and others added 5 commits March 14, 2019 13:06
Co-Authored-By: renatocaval <[email protected]>
Co-Authored-By: renatocaval <[email protected]>
Co-Authored-By: renatocaval <[email protected]>
Co-Authored-By: renatocaval <[email protected]>
Copy link
Contributor

@marcospereira marcospereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Let's merge when green.

@ignasi35 ignasi35 merged commit 7759358 into lagom:master Mar 14, 2019
@ignasi35
Copy link
Contributor

ignasi35 commented Mar 14, 2019

Cherrypicked 1.5.x d527586

ignasi35 pushed a commit that referenced this pull request Mar 15, 2019
@octonato octonato deleted the migration-guide branch March 21, 2019 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants