Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sbt 1 to build Lagom itself #1329

Closed
marcospereira opened this issue Apr 26, 2018 · 2 comments
Closed

Use sbt 1 to build Lagom itself #1329

marcospereira opened this issue Apr 26, 2018 · 2 comments
Assignees
@dwijnand
Labels
help wanted Ready and waiting for a volunteer status:in-progress

Comments

@marcospereira
Copy link
Contributor

Lagom Version

1.4+.

Not sure if we should target 1.4 here or go straight to 1.5.

Expected Behavior

Lagom already cross build its plugin to sbt 0.13 and 1, but Lagom itself is not build using sbt 1. sbt tracks the progress of projects already using sbt 1 here:

https://github.com/sbt/sbt/wiki/library-sbt-1.x-migration

Not to be confused with plugins migration.

Actual Behavior

Lagom is not built with sbt 1.
@TimMoore TimMoore added the help wanted Ready and waiting for a volunteer label Jun 18, 2018
@erip
Copy link
Contributor

erip commented Jul 18, 2018 •
edited
Loading

Edit: See PR.

I'm going to make a (potentially non-exhaustive) list of plugins that need to be updated for compatibility here... the RHS of the arrow is the at-least version. Once someone makes a PR, it might be good to copy there for WIP status.

@erip erip mentioned this issue Jul 18, 2018
Closed
13 tasks
@dwijnand dwijnand mentioned this issue Jan 17, 2019
Closed
@dwijnand dwijnand added this to the Lagom 1.6.0 milestone Jan 29, 2019
@marcospereira marcospereira mentioned this issue Jan 30, 2019
Closed
9 tasks
@dwijnand dwijnand added ready and removed backlog labels Feb 14, 2019
@dwijnand dwijnand mentioned this issue Mar 15, 2019
Closed
@dwijnand dwijnand modified the milestones: Lagom 1.6.0, Lagom 1.5.x Mar 15, 2019
@dwijnand dwijnand mentioned this issue Mar 15, 2019
Closed
@dwijnand dwijnand self-assigned this Mar 15, 2019
@octonato octonato mentioned this issue Mar 15, 2019
Closed
33 tasks
dwijnand added a commit to dwijnand/lagom that referenced this issue Mar 15, 2019
@dwijnand
Use sbt 1 to build Lagom itself
e3d8b25 
Fixes lagom#1329
@dwijnand dwijnand mentioned this issue Mar 15, 2019
Closed
dwijnand added a commit to dwijnand/lagom that referenced this issue Mar 18, 2019
@dwijnand
Use sbt 1 to build Lagom itself
f41dc73 
Fixes lagom#1329
dwijnand added a commit to dwijnand/lagom that referenced this issue Mar 18, 2019
@dwijnand
Use sbt 1 to build Lagom itself
b61915f 
Fixes lagom#1329
@dwijnand
Copy link
Contributor

Some progress was made in #1796 however something about using Java 11 with sbt 1.2.8 breaks both Lagom's build and Lagom's docs build. I'll have to get back to this later.

@dwijnand dwijnand removed this from the Lagom 1.5.x milestone Mar 19, 2019
dwijnand added a commit to dwijnand/lagom that referenced this issue Mar 21, 2019
@dwijnand
Use sbt 1 to build Lagom itself
a6735f4 
Fixes lagom#1329
dwijnand added a commit to dwijnand/lagom that referenced this issue Mar 22, 2019
@dwijnand
Use sbt 1 to build Lagom itself
f5436c4 
Fixes lagom#1329
dwijnand added a commit to dwijnand/lagom that referenced this issue Mar 22, 2019
@dwijnand
Use sbt 1 to build Lagom itself
772d21c 
Fixes lagom#1329
@dwijnand dwijnand mentioned this issue Mar 22, 2019
Merged
dwijnand added a commit to dwijnand/lagom that referenced this issue Mar 22, 2019
@dwijnand
Use sbt 1 to build Lagom itself
ad9b042 
Fixes lagom#1329
dwijnand added a commit to dwijnand/lagom that referenced this issue Mar 22, 2019
@dwijnand
Use sbt 1 to build Lagom itself
12688a6 
Fixes lagom#1329
dwijnand added a commit to dwijnand/lagom that referenced this issue Mar 23, 2019
@dwijnand
Use sbt 1 to build Lagom itself
9c046c8 
Fixes lagom#1329
dwijnand added a commit to dwijnand/lagom that referenced this issue Mar 25, 2019
@dwijnand
Use sbt 1 to build Lagom itself
0e00517 
Fixes lagom#1329
@marcospereira marcospereira mentioned this issue Mar 25, 2019
Closed
66 tasks
dwijnand added a commit to dwijnand/lagom that referenced this issue Mar 25, 2019
@dwijnand
Use sbt 1 to build Lagom itself
ea98961 
Fixes lagom#1329
marcospereira pushed a commit that referenced this issue Mar 25, 2019
@dwijnand @marcospereira
Use sbt 1 to build Lagom itself (#1819)
0294936 
* Drop unnecessary publishLocal before scripted

If all is setup properly with scriptedDependencies it shouldn't be
necessary to publish locally as an independent step of running scripted.

* Use sbt 1 to build Lagom itself

Fixes #1329
marcospereira added a commit that referenced this issue Mar 26, 2019
@marcospereira
Use sbt 1 to build Lagom itself (#1819) (#1827)
44abb8c 
* Drop unnecessary publishLocal before scripted

If all is setup properly with scriptedDependencies it shouldn't be
necessary to publish locally as an independent step of running scripted.

* Use sbt 1 to build Lagom itself

Fixes #1329
dwijnand pushed a commit to dwijnand/lagom that referenced this issue Mar 26, 2019
@marcospereira @dwijnand
Use sbt 1 to build Lagom itself (lagom#1819) (lagom#1827)
c610cec 
Fixes lagom#1329

(cherry picked from commit 44abb8c)
dwijnand pushed a commit to dwijnand/lagom that referenced this issue Mar 26, 2019
@marcospereira @dwijnand
Use sbt 1 to build Lagom itself (lagom#1819) (lagom#1827)
71843cc 
Fixes lagom#1329

(cherry picked from commit 44abb8c)
dwijnand pushed a commit to dwijnand/lagom that referenced this issue Mar 26, 2019
@marcospereira @dwijnand
Use sbt 1 to build Lagom itself (lagom#1819) (lagom#1827)
84ab235 
Fixes lagom#1329

(cherry picked from commit 44abb8c)
dwijnand pushed a commit to dwijnand/lagom that referenced this issue Mar 26, 2019
@marcospereira @dwijnand
Use sbt 1 to build Lagom itself (lagom#1819) (lagom#1827)
a10f575 
Fixes lagom#1329

(cherry picked from commit 44abb8c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dwijnand dwijnand

Labels
help wanted Ready and waiting for a volunteer status:in-progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Build Lagom with sbt 1.x
4 participants
@marcospereira @TimMoore @dwijnand @erip