Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to sbt 1.x #183

Merged
merged 6 commits into from
Mar 27, 2019
Merged

Conversation

ignasi35
Copy link
Contributor

@ignasi35 ignasi35 commented Mar 26, 2019

Fixes #123

I haven't done any attempt at improving the code (especially SimpleHTTPServer). We can address that on separate PRs.

@ignasi35
Copy link
Contributor Author

Special mention to @muuki88 for the breadcrumbs he left on sbt/sbt-native-packager#1000 wrt PathFinder. Very helpful :-)

Copy link
Contributor

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

No blockers, just alternative fixes.

build.sbt Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
dwijnand and others added 5 commits March 27, 2019 13:20
Co-Authored-By: ignasi35 <[email protected]>
Co-Authored-By: ignasi35 <[email protected]>
Co-Authored-By: ignasi35 <[email protected]>
Co-Authored-By: ignasi35 <[email protected]>
Co-Authored-By: ignasi35 <[email protected]>
@ignasi35
Copy link
Contributor Author

Thanks @dwijnand for the suggestions! :-)

@dwijnand dwijnand merged commit 0224ec1 into lagom:template Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants