Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyPi deployment failed #149

Closed
AntoineDao opened this issue Jun 18, 2019 · 4 comments · Fixed by #150
Closed

PyPi deployment failed #149

AntoineDao opened this issue Jun 18, 2019 · 4 comments · Fixed by #150
Labels
bug Something isn't working released

Comments

@AntoineDao
Copy link
Member

The latest PyPi deployment failed because of something in the long description section not rendering properly. Not sure how or why as it's worked in the past.

https://travis-ci.org/ladybug-tools/ladybug/jobs/546918735#L918
@AntoineDao AntoineDao added the bug Something isn't working label Jun 18, 2019
@mostaphaRoudsari
Copy link
Member

The description failed to render in the default format of reStructuredText.

This might be because the description is Markdown not reStructuredText which has been clarified here:

ladybug/setup.py

Line 16 in 7e3d815

long_description_content_type="text/markdown",

@AntoineDao
Copy link
Member Author

AntoineDao commented Jun 18, 2019 •
edited
Loading

Can't see any difference in readme file or the dependencies that would lead to this error... v0.4.0...v0.4.2

Might be worth just running the markdown file through a converter and then dumping it as .rst rather than counting to twine/Pypi to sort it out?

mostaphaRoudsari added a commit that referenced this issue Jun 21, 2019
@mostaphaRoudsari
fix(pypi): fix deployment issue to pypi
96b0458 
I updated the libraries locally and was able to create the package successfully. I'm sending the PR directly to master so we see if it is really fixing the issue.

also see: pypi/warehouse#4079 (comment)

fixes #149
@mostaphaRoudsari mostaphaRoudsari mentioned this issue Jun 21, 2019
Merged
mostaphaRoudsari added a commit that referenced this issue Jun 21, 2019
@mostaphaRoudsari
fix(pypi): fix deployment issue to pypi
984c410 
I updated the libraries locally and was able to create the package successfully. I'm sending the PR directly to master so we see if it is really fixing the issue.

also see: pypi/warehouse#4079 (comment)

fixes #149
mostaphaRoudsari added a commit that referenced this issue Jun 21, 2019
@mostaphaRoudsari
fix(pypi): fix deployment issue to pypi
1f93413 
I updated the libraries locally and was able to create the package successfully. I'm sending the PR directly to master so we see if it is really fixing the issue.

also see: pypi/warehouse#4079 (comment)

fixes #149
@ladybugbot
Copy link
Contributor

🎉 This issue has been resolved in version 0.4.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@mostaphaRoudsari
Copy link
Member

... and finally the page is rendered correctly. We should make the same change to all the other repositories.

https://pypi.org/project/lbt-ladybug/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(pypi): fix deployment issue to pypi ladybug-tools/ladybug
3 participants
@mostaphaRoudsari @AntoineDao @ladybugbot