feat(at): Added apparent temperature(AT). #44
Conversation
There was a problem hiding this comment.
This is a great PR, @janeliutw . Thank you for putting it together.
The code is good enough to merge in so I'm approving it but I had a few minor comments that are all about styling and should be pretty quick to implement. If you are able to address the comments before we merge it in, it would be a big help.
Also, I realize the ET stuff is more complex and we can break it out into another issue and another PR.
chriswmackey
added
hacktoberfest
new development
A minor update to improve code efficiency.
|
@chriswmackey Thank you for the code review. I have updated the files according to your comments. Let me know if you have more concerns or comments, I am happy to adjust my code. |
|
This looks great, @janeliutw . Thank your for addressing all of the comments. Let's merge this in and thanks again for putting together a good Hacktoberfest contribution! |
|
And welcome to the contributor's list! |
|
🎉 This PR is included in version 0.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
Good evening @janeliutw Best, -- |
issue #33
This PR only covers adding the apparent temperature. I also added two unit tests to cover the functions.
I was confused by the "Radiative-effective temperature" in the effective temperature legacy code, not sure which value -- TE or TRE, should I return when I re-write the method. Hence I didn't complete the effective temperature part. But I am happy to work on it if anyone can help me understand this part.