Removes warning and fixes issues #25 and #65 #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the issue reported on ladybug-podcast#25 and ladybug-podcast#65. From what I researched it is related to the bug facebook/react#5479 and their suggestion is to replace tag <p /> with <div /> when using `dangerouslySetInnerHTML` attribute
This was referenced Apr 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
From what I quickly googled, it was reported here dangerouslySetInnerHTML does not work on production builds gatsbyjs/gatsby#11108 and they subsequently point to dangerouslySetInnerHTML not reconciling for P tags - likely due to nested P tags facebook/react#5479.