Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update superagent + use trustLocalhost() #554

Merged
merged 3 commits into from
Mar 9, 2019
Merged

Update superagent + use trustLocalhost() #554

merged 3 commits into from
Mar 9, 2019

Conversation

rimiti
Copy link
Contributor

@rimiti rimiti commented Mar 8, 2019

Hello,

Related pull request: #553

Fyi: @gjohnson

Regards,

@rimiti rimiti self-assigned this Mar 8, 2019
@rimiti rimiti requested a review from gjohnson March 8, 2019 12:56
@coveralls
Copy link

coveralls commented Mar 8, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 385

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.285%
Totals Coverage Status
Change from base Build 379: 0.0%
Covered Lines: 136
Relevant Lines: 140
💛 - Coveralls

@rimiti
Copy link
Contributor Author

rimiti commented Mar 8, 2019 •
edited
Loading

@gjohnson Can you review it ? 🙏
(I'm waiting for your approval for merging + releasing) 🚀

gjohnson
gjohnson approved these changes Mar 8, 2019
View reviewed changes
Copy link
Contributor

@gjohnson gjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let’s make sure we do a major bump.

@rimiti rimiti added this to the v4.0.0 milestone Mar 9, 2019
@rimiti rimiti merged commit 5914936 into master Mar 9, 2019
@rimiti rimiti deleted the use-trust-localhost branch March 9, 2019 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjohnson gjohnson gjohnson approved these changes

Assignees

@rimiti rimiti

Labels
documentation enhancement next-release Next release
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@rimiti @coveralls @gjohnson @aheckmann @karlbecker @tejashah88