Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close koa servers when if tests finish #522

Closed
wants to merge 1 commit into from

Conversation

Ohadbasan
Copy link

This PR fixes the problem described at
#437
supertest did not shut down koa.js servers when tests finish running.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 345

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 96.861%

Totals Coverage Status
Change from base Build 330: -0.4%
Covered Lines: 136
Relevant Lines: 140

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 345

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 96.861%

Totals Coverage Status
Change from base Build 330: -0.4%
Covered Lines: 136
Relevant Lines: 140

💛 - Coveralls

@Ohadbasan
Copy link
Author

Ohadbasan commented Nov 20, 2018

I see that the node 10 tests fail
not sure what causes the behaviour change.
I can investigate that.
if (!addr || (addr.address === '::' && !process.version.startsWith('v10'))) { this._server = app.listen(0); }

this will 'solve' the problem but I guess we don't want that

@Ohadbasan Ohadbasan closed this Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants