-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support unix sockets #961
Support unix sockets #961
Conversation
Thanks for the PR, but that is a hack. I think it's inappropriate to use Python uses |
@pornel Thanks review, I've fixed. |
That's better. Thanks! Can you add tests to ensure we don't break it? |
@pornel yes, added 🍰 |
retry build please |
I've restarted the build |
Oops, Node.js 0.10 has failed. I'll check it later. |
Sorry, I added the comment about the failing build a bit earlier, but removed it as I'm not sure if this PR (or the work for this PR) was the cause. Thanks for looking into it. |
Have you checked node 0.10? If there's no simple fix for it I don't mind disabling the feature in node 0.10 (i.e. detect node 0.10 in tests and skip the tests). 0.10 is the IE6 of nodes. |
Since 0.10 life ends this month we can go ahead and merge this. |
related: #779
I've implemented it. maybe this is not breaking change.