Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unix sockets #961

Merged
merged 5 commits into from
Oct 6, 2016
Merged

Conversation

kanreisa
Copy link
Contributor

@kanreisa kanreisa commented Apr 4, 2016

related: #779

I've implemented it. maybe this is not breaking change.

@kornelski
Copy link
Contributor

Thanks for the PR, but that is a hack.

I think it's inappropriate to use http: URL scheme for something that is not true HTTP over TCP/IP. unix is not a special, reserved hostname.

Python uses http+unix scheme for this: https://pypi.python.org/pypi/requests-unixsocket/ which seems more appropriate and avoids ambiguity.

@kanreisa
Copy link
Contributor Author

kanreisa commented Apr 4, 2016

@pornel Thanks review, I've fixed.

@kornelski
Copy link
Contributor

That's better. Thanks! Can you add tests to ensure we don't break it?

@kanreisa
Copy link
Contributor Author

kanreisa commented Apr 5, 2016

@pornel yes, added 🍰

@kanreisa
Copy link
Contributor Author

retry build please

@kornelski
Copy link
Contributor

I've restarted the build

@kanreisa
Copy link
Contributor Author

Oops, Node.js 0.10 has failed. I'll check it later.

@philpill
Copy link

philpill commented Apr 19, 2016

Sorry, I added the comment about the failing build a bit earlier, but removed it as I'm not sure if this PR (or the work for this PR) was the cause. Thanks for looking into it.

@kornelski
Copy link
Contributor

kornelski commented Apr 22, 2016

Have you checked node 0.10? If there's no simple fix for it I don't mind disabling the feature in node 0.10 (i.e. detect node 0.10 in tests and skip the tests). 0.10 is the IE6 of nodes.

@kornelski kornelski merged commit 6e6f48f into ladjs:master Oct 6, 2016
@kornelski
Copy link
Contributor

Since 0.10 life ends this month we can go ahead and merge this.

Morita0711 added a commit to Morita0711/npm-superurgent that referenced this pull request Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants