Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use single export #1778

Merged
merged 1 commit into from
Oct 8, 2023
Merged

chore: use single export #1778

merged 1 commit into from
Oct 8, 2023

Conversation

jimmywarting
Copy link
Contributor

@jimmywarting jimmywarting commented Aug 21, 2023

I'm going to try and group export and put them at the bottom last and also using explicit path (with extension) cuz this really makes it much more easier to refactor the code into ESM at a later stage.

It's much more easier to see what things gets exported when they are put last as a group

Checklist

  • I have ensured my pull request is not behind the beta branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@titanism
Copy link
Collaborator

❤️ it - would love undici here (writing because we're actually implementing custom retry logic as a simple wrapper for undici)

@titanism
Copy link
Collaborator

titanism commented Oct 6, 2023

@jimmywarting feel free to merge this PR if it's ready

@jimmywarting jimmywarting merged commit a46fff1 into ladjs:beta Oct 8, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants