Documented FormData support in .send() #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wanted to use superagent to send an HTML form, because of some `<input type="file">` fields. Browser support section in the master branch's README hints that `FormData` is somehow supported, but I couldn't find any mentions of it in the documentation website. After blindly trying using `.field()` and `.append()`, I found out that it works with `.send()`.
|
Thank you |
kornelski
pushed a commit
that referenced
this pull request
Aug 8, 2017
I wanted to use superagent to send an HTML form, because of some `<input type="file">` fields. Browser support section in the master branch's README hints that `FormData` is somehow supported, but I couldn't find any mentions of it in the documentation website. After blindly trying using `.field()` and `.append()`, I found out that it works with `.send()`.
kornelski
added a commit
that referenced
this pull request
Aug 8, 2017
* commit '4e21f1c509c3ee09ea4031c27855ed8e9ddc0d35': Documented FormData support in .send() (#1260) Update supported node version to >= 4.0 (#1248) Keep nodelay always on support TCP_NODELAY option (#1240) timeout options.read property is not used. grammar misstype (#1234) Fix spelling mistake in the docs (#1232) Revert test 'fixes' - see PR #1227 Support passphrase with pfx certificate Fix build errors Send payload in query string for GET and HEAD shorthand API Fix xml tests that broke with mime update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to use superagent to send an HTML form, because of some
<input type="file">fields. Browser support section in the master branch's README hints thatFormDatais somehow supported, but I couldn't find any mentions of it in the documentation website. After blindly trying using.field()and.append(), I found out that it works with.send().