Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update index.js to address deprecation warning #4

Closed

Conversation

mario-merino
Copy link

No description provided.

@codecov
Copy link

codecov bot commented Feb 5, 2019

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #4   +/-   ##
=======================================
  Coverage   81.25%   81.25%           
=======================================
  Files           1        1           
  Lines          48       48           
=======================================
  Hits           39       39           
  Misses          9        9
Impacted Files Coverage Δ
index.js 81.25% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e30720...5ba79df. Read the comment docs.

Copy link

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my perspective but I defer to @niftylettuce

@niftylettuce
Copy link
Contributor

@vkarpov15 what version of Mongoose was countDocuments added? we may need to do a peerDependency with that particular >= version.

Also I think we are missing this from docs on Mongoose with the count -> countDocuments deprecation:

Note that if you migrate from count to countDocuments where are query operators including, but not limited to $where, $near, and $nearSphere that need replaced. See https://mongodb.github.io/node-mongodb-native/3.1/api/Collection.html#countDocuments for more information.

@paullbn
Copy link

paullbn commented Sep 5, 2019

Hi!
Will this PR be merged?

@niftylettuce
Copy link
Contributor

@paullbn yes, just need a min

@niftylettuce
Copy link
Contributor

Please use mongoose-slug-plugin newest version 2.0.0:

npm install mongoose-slug-plugin@latest

Versions older than v2.0.0 have the following deprecation message now upon installation:

"If you upgrade to v2.0.0+ please ensure you are using Mongoose v5.2+ or greater"

Any issues please let me know.

cc @paullbn

@niftylettuce niftylettuce reopened this Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants