feat: bump tf requirement to 1.5; add checks (#21)

* feat: bump tf requirement to 1.5; add checks

* misc: trigger a release job

* misc: another noop to trigger release

README.md

@@ -13,7 +13,7 @@ All code contributions made by Lacework customers to this repo are considered 
 
 | Name | Version |
 |------|---------|
-| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 0.13 |
+| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.5 |
 | <a name="requirement_azuread"></a> [azuread](#requirement\_azuread) | ~> 2.45.0 |
 | <a name="requirement_azurerm"></a> [azurerm](#requirement\_azurerm) | ~> 3.77.0 |
 | <a name="requirement_lacework"></a> [lacework](#requirement\_lacework) | >= 1.18 |

checks.tf

@@ -0,0 +1,24 @@
+// Provides some guardrails for common misconfiguration
+// Those are only available after Terraform v1.5. 
+
+/* When we are doing a non-global/regional deployment, we expect some global resources 
+to have been created. One way to check that is to ensure we can reference them via
+the global_module_reference attribute.
+*/
+
+check "check_global_resource_condition" {
+  assert {
+    condition = var.global || (
+      length(var.global_module_reference.storage_account_id) > 0 &&
+      length(var.global_module_reference.scanning_subscription_role_definition_id) > 0 &&
+      length(var.global_module_reference.monitored_subscription_role_definition_id) > 0 &&
+      length(var.global_module_reference.blob_container_name) > 0 &&
+      length(var.global_module_reference.key_vault_id) > 0 &&
+      length(var.global_module_reference.sidekick_principal_id) > 0 &&
+      length(var.global_module_reference.sidekick_client_id) > 0 &&
+      length(var.global_module_reference.key_vault_secret_name) > 0 &&
+      length(var.global_module_reference.key_vault_uri) > 0
+    )
+    error_message = "Some resources have not been referenced correctly during a non-global deployment"
+  }
+}

main.tf

@@ -131,30 +131,6 @@ locals {
   module_version = fileexists(local.version_file) ? file(local.version_file) : ""
 }
 
-/* When we are doing a non-global/regional deployment, we expect some global resources 
-to have been created. One way to check that is to ensure we can reference them via
-the global_module_reference attribute.
-TODO: Unfortunately this wouldn't work because the `check` predicate is only supported after 
-TF 1.5 but we need to be backward compatible. We should uncomment this once Terraform major 
-version is upgraded.
-*/
-/* check "check_global_resource_condition" {
-  assert {
-    condition = var.global || (
-      length(var.global_module_reference.storage_account_id) > 0 &&
-      length(var.global_module_reference.scanning_subscription_role_definition_id) > 0 &&
-      length(var.global_module_reference.monitored_subscription_role_definition_id) > 0 &&
-      length(var.global_module_reference.blob_container_name) > 0 &&
-      length(var.global_module_reference.key_vault_id) > 0 &&
-      length(var.global_module_reference.sidekick_principal_id) > 0 &&
-      length(var.global_module_reference.sidekick_client_id) > 0 &&
-      length(var.global_module_reference.key_vault_secret_name) > 0 &&
-      length(var.global_module_reference.key_vault_uri) > 0
-    )
-    error_message = "Some resources have not been referenced correctly during a non-global deployment"
-  }
-}
- */
 resource "random_id" "uniq" {
   byte_length = 2
 }

versions.tf

@@ -1,5 +1,5 @@
 terraform {
-  required_version = ">= 0.13"
+  required_version = ">= 1.5"
   required_providers {
     azuread = {
       source  = "hashicorp/azuread"