Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(release): update github release action #156

Merged
merged 5 commits into from
Feb 8, 2024

Conversation

tmac1973
Copy link
Contributor

@tmac1973 tmac1973 commented Feb 6, 2024

Switch from using the python-semantic-release action to running it in a script.

Issue:

https://lacework.atlassian.net/browse/GROW-2746

@tmac1973 tmac1973 requested a review from a team as a code owner February 6, 2024 22:13
Copy link
Contributor

@ipcrm ipcrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; not sure about that git user

.github/workflows/python-release.yml Outdated Show resolved Hide resolved
.github/workflows/python-release.yml Outdated Show resolved Hide resolved
@tmac1973 tmac1973 force-pushed the tmacdonald/GROW-2746/semantic-release-action branch from 8431725 to e88c841 Compare February 7, 2024 17:15
@tmac1973 tmac1973 requested a review from ipcrm February 7, 2024 17:44
@tmac1973 tmac1973 force-pushed the tmacdonald/GROW-2746/semantic-release-action branch from 4bc41e3 to 2715a41 Compare February 8, 2024 18:12
Signed-off-by: Timothy MacDonald <[email protected]>
Copy link
Contributor

@ipcrm ipcrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tmac1973 tmac1973 merged commit da1f4d8 into main Feb 8, 2024
8 checks passed
@tmac1973 tmac1973 deleted the tmacdonald/GROW-2746/semantic-release-action branch February 8, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants