Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create AzureAD intg from CLI (manual) #1601

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

Manan-Bhatia-0
Copy link
Contributor

@Manan-Bhatia-0 Manan-Bhatia-0 commented Mar 22, 2024

Summary

This PR adds the ability to create Azure Active Directory Activity Log integrations manually via the LW CLI.

How did you test this change?

Tested by building the CLI locally.

  • make test
  • make prepare
  • make install-cli
  • /usr/local/bin/lacework cloud-account create
    • Select Azure Active Directory Activity Log and follow the prompts
  • Screenshot [CLI]:
Screenshot 2024-03-22 at 12 15 16 PM
  • Screenshot [Result on UI]:
Screenshot 2024-03-22 at 12 15 52 PM

Issue

RAIN-92779

@Manan-Bhatia-0 Manan-Bhatia-0 marked this pull request as ready for review March 22, 2024 19:17
@Manan-Bhatia-0 Manan-Bhatia-0 requested a review from a team as a code owner March 22, 2024 19:17
Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afiune afiune changed the title feat(RAIN-92779): create AzureAD intg from CLI (manual) feat: create AzureAD intg from CLI (manual) Mar 22, 2024
@afiune afiune merged commit 0a5ced9 into main Mar 22, 2024
11 checks passed
@afiune afiune deleted the RAIN-92779-AzureAD-CLI-manual-intg-config branch March 22, 2024 20:32
@@ -301,6 +301,7 @@ func promptCreateCloudAccount() error {
"GCP Audit Log PubSub",
"Azure Config",
"Azure Activity Log",
"Azure Active Directory Activity Log",
Copy link

@selvats selvats Mar 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new name for Azure AD is Microsoft Entra ID as per https://www.microsoft.com/en-us/security/business/identity-access/microsoft-entra-id. We might want to reflect the name change here and say Microsoft Entra ID (formerly Azure Active Directory) in the README.

@lacework-releng lacework-releng mentioned this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants