feat(cli): configure in non-interactive mode #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
>As a Lacework CLI user that uses the tool in CI/CD Pipelines, >I want to have a non-interactive way to configure the Lacework CLI, >So I don't have to manually create the config file `~/.lacework.toml` inside my pipeline. When a user runs: ``` $ lacework configure -a foo -k bar -s bubu --noninteractive ``` The result is the creation of the `~/.lacework.toml` without asking the user to validate the inputs. (non-interactive mode) The command loads these settings from all sources, as usual, environment variables, parameters (including `--json_file`), and the actual config file. Closes #112 Signed-off-by: Salim Afiune Maya <[email protected]>
afiune
added
feat
scottford-lw
suggested changes
Jul 6, 2020
There was a problem hiding this comment.
@afiune First of all, --noninteractive did not seem to work with lacework configure...
I was still prompted to accept my input...
lacework configure -a foo -k TECHALLY_561DDEAD5CC413252FD1D579EAD9C2B882B694872291FOO -s _TEST********* --noninteractive scottford@scott-fords-mbp
▸ Account: foo
▸ Access Key ID: TECHALLY_561DDEAD5CC413252FD1D579EAD9C2B882B694872291FOO
▸ Secret Access Key: (*****************************bFOO)
You are all set!
Second, if we are going to introduce a --noninteractive flag for configure we will need to update the --help because there is already a --noninteractive global flag and our help says it is disable interactive progress bars (i.e. 'spinners')
|
You tested that single case where it does NOT work! Amazing 🎉 thank you, fixing it now.
|
Signed-off-by: Salim Afiune Maya <[email protected]>
|
|
Signed-off-by: Salim Afiune Maya <[email protected]>
afiune
force-pushed
the
afiune/configure/non-interactive
branch
from
ec9a340
to
8333781
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user runs:
The result is the creation of the
~/.lacework.tomlwithout asking the userto validate the inputs. (non-interactive mode)
The command loads these settings from all sources, as usual, environment
variables, parameters (including
--json_file), and the actual config file.Closes #112
Signed-off-by: Salim Afiune Maya [email protected]